Better import error #6072
Merged
Better import error #6072
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I didn't know how to use "use" initially, and an error message like this would have solved quite a bit of frustration. I think this properly handles cases where it's not appropriate but I'm not sure.
|
What sort of errors does this trigger on? Can you provide a test case? |
|
Literally a testcase, in the test suite? Otherwise, afaik, it only triggers when you have: use foo;which is invalid (I think it is, anyway, not sure, 🆕bie. Currently reported as "unresolved import"), but will NOT trigger on use foo::bar;which is valid, but if bar doesn't exist is reported as "failed to resolve imports", and if foo doesn't exist an additional error is reported, "unresolved name", although the span is wrong... I'll open an issue for that. |
|
Ah, I see. Seems innocuous enough to not need a test (not even sure how you'd test this in the first place). |
|
r+ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.